From 1e3af04dd9a61e2acde4bf86de4f69a24fcb3e22 Mon Sep 17 00:00:00 2001 From: =?utf8?q?S=C3=A9bastien=20Wilmet?= Date: Thu, 4 Apr 2013 13:30:42 +0200 Subject: [PATCH] gtk_text_buffer_create_tag(): returns NULL on failure Returns NULL in case of a duplicated tag name in the tag table. It is still a programmer error to duplicate a name, but if it happens the behavior is a little nicer (and hopefully doesn't crash). https://bugzilla.gnome.org/show_bug.cgi?id=614717 --- gtk/gtktextbuffer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gtk/gtktextbuffer.c b/gtk/gtktextbuffer.c index e562c331ec..6a03b55f2a 100644 --- a/gtk/gtktextbuffer.c +++ b/gtk/gtktextbuffer.c @@ -2493,7 +2493,11 @@ gtk_text_buffer_create_tag (GtkTextBuffer *buffer, tag = gtk_text_tag_new (tag_name); - gtk_text_tag_table_add (get_table (buffer), tag); + if (!gtk_text_tag_table_add (get_table (buffer), tag)) + { + g_object_unref (tag); + return NULL; + } if (first_property_name) { -- 2.30.2